linux-kernel - RE: [RFC][Patch 1/4] kprobe fast unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <16D5B9AB904B0B46B22A27002EE3A8C82793BB@scsmsx415.amr.corp.intel.com>
Date:	Fri, 23 Mar 2007 11:12:22 -0700
From:	"Stone, Joshua I" <joshua.i.stone@...el.com>
To:	"Keshavamurthy, Anil S" <anil.s.keshavamurthy@...el.com>,
	"Masami Hiramatsu" <masami.hiramatsu.pt@...achi.com>
Cc:	"Ananth N Mavinakayanahalli" <ananth@...ibm.com>,
	"Prasanna S Panchamukhi" <prasanna@...ibm.com>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"SystemTAP" <systemtap@...rces.redhat.com>,
	"Satoshi Oshima" <soshima@...hat.com>,
	"Hideo Aoki" <haoki@...hat.com>,
	"Yumiko Sugita" <yumiko.sugita.yf@...achi.com>,
	"Frank Ch. Eigler" <fche@...hat.com>, <hch@...radead.org>
Subject: RE: [RFC][Patch 1/4] kprobe fast unregistration

Keshavamurthy, Anil S wrote:
> I agree with Christop that the interface is horrible and error prone.
> However, I see the use case where people want to disable the probes
> quickly and would like to reenable them again. Looking closely at
> your patch, 
> I think this can be acheived.
> Here is my suggestion.
> 
>> Here is an example code.
>> --
>> struct kprobes *p;
>> for_each_probe(p) {
>> 	unregister_kprobe_fast(p);
>         ^^^^^^^^^^^^^^^^^^^^^^
> Change this to disable_kprobe(p), which is essentially the same as
> what you have implemented. And also provide an opposite function
> to reenable_kprobe(p) which enables the disabled probe again.
>> }
>> commit_kprobes();
>   ^^^^^^^^^^^^^^
> Change this to unregister_disabled_kprobes(), which essentially
> unregisters all the disabled probes.

The ability to disable/reenable kprobes would be an interesting
enhancement.  However, unregister_disabled_kprobes() shouldn't have a
global effect, because there might be a concurrent kprobes user that
disabled a probe with the intention of reenabling it later.


Josh Stone
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/