linux-kernel - Re: [PATCH 2.6.21-rc5] Flush MSI-X table writes (rev 3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1y7leh27w.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 30 Mar 2007 15:05:07 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
Cc:	"Greg KH" <gregkh@...e.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-pci@...ey.karlin.mff.cuni.cz>,
	<linux-kernel@...r.kernel.org>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>
Subject: Re: [PATCH 2.6.21-rc5] Flush MSI-X table writes (rev 3)

"Williams, Mitch A" <mitch.a.williams@...el.com> writes:

> Agreed, this is a subtle bug, and was a real hairball to track down.
> Even so, I'm surprised that nobody else has dug into this, since it
> should affect anybody running MSI-X.  I originally thought I was seeing
> a hardware bug, which is why I dug more deeply into the issue.
>
> If Eric is seeing bug reports related to "no vector for IRQ" in the
> wild, then I have to change my stance and agree that this should be
> pushed to -stable.  Every one of those messages indicates that we
> hit the race condition.

There is a non MSI-X cause as well with the ioapics that I believe I have
now worked around.  It was a lot harder because ioapics don't obey the
pci ordering rules.  Although the primary culprit was receiving a second
instance of the an irq before we had acknowledged the first instance.

I had just about concluded that there was likely a second cause for
the "no vector for IRQ" message but I had not been able to confirm
that until I saw the first version of this patch.

In general the rule for -stable is that a fix has to go to -linus
first.  It makes it simple to see if the normal QA has been done
on the patch before we push it towards stable.  So this patch needs to
hit 2.6.21 first.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/