[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070330210534.M37380@chilan.com>
Date: Fri, 30 Mar 2007 23:06:02 +0200
From: "Grzegorz Chwesewicz" <grzegorz.chwesewicz@...lan.com>
To: Andi Kleen <ak@...e.de>,
Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Mark Langsdorf <mark.langsdorf@....com>,
Len Brown <lenb@...nel.org>,
"Morrow, William" <William.Morrow@....com>,
"Crouse, Jordan" <jordan.crouse@...mail.amd.com>,
Thomas Gleixner <tglx@...utronix.de>,
Pavel Machek <pavel@....cz>, Ingo Molnar <mingo@...e.hu>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Nick Piggin <nickpiggin@...oo.com.au>,
Mingming Cao <cmm@...ibm.com>, Adrian Bunk <bunk@...sta.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
Mariusz Kozlowski <m.kozlowski@...land.pl>,
Oliver Pinter <oliver.pntr@...il.com>,
Sid Boyce <g3vbv@...eyonder.co.uk>,
Nick Piggin <npiggin@...e.de>,
Jens Axboe <jens.axboe@...cle.com>,
Thomas Renninger <trenn@...e.de>
Subject: Re: [PATCH] i386: add command line option "local_apic_timer_c2_ok"
On Fri, 30 Mar 2007 00:05:39 +0200, Andi Kleen wrote
> On Thursday 29 March 2007 23:16, Linus Torvalds wrote:
> >
> > On Thu, 29 Mar 2007, Andi Kleen wrote:
> > >
> > > Here's a patch. I don't have a system with C1E, so i only tested that
> > > the apic timer still works on a older AMD box.
> >
> > I think this looks better than what we have now, but it would look even
> > better if the core CPUID stuff was in arch/i386/kernel/cpu/amd.c, and we
> > simply had X86_FEATURE_BROKEN_C1_LAPIC etc..
> >
> > And then the apic.c code would just check
> >
> > if (boot_cpu_has(X86_FEATURE_BROKEN_C1_LAPIC))
> > return -1;
> >
> > or similar.
>
> Ok fair point. Here's an updated patch.
This patch also works. If You want bootlog or output of /proc/interrupts I can
post it.
--
Greetings - CeHo - Grzegorz Chwesewicz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists