linux-kernel - RE: [PATCH] msi: Immediately mask and unmask msi-x irqs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08FE5CC30C9A3F41BF819A502CF7BF6E01043C7D@fmsmsx411.amr.corp.intel.com>
Date:	Tue, 3 Apr 2007 10:24:40 -0700
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Greg KH" <gregkh@...e.de>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-pci@...ey.karlin.mff.cuni.cz>,
	<linux-kernel@...r.kernel.org>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>
Subject: RE: [PATCH] msi: Immediately mask and unmask msi-x irqs.

Acked-by: Mitch Williams <mitch.a.williams@...el.com>

>This is a simplified and actually more comprehensive form of a bug
>fix from Mitch Williams <mitch.a.williams@...el.com>.
[snip]
>Then if people do have a kernel message stating "No irq for vector" we
>will know it is yet another novel cause that needs a complete new
>investigation.
>
>So here is a one liner that will hopefully be a part of 2.6.21.
>
>Cc: Mitch Williams <mitch.a.williams@...el.com>
>Cc: Greg KH <greg@...ah.com>
>Cc: Andrew Morton <akpm@...ux-foundation.org>
>Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>---
> drivers/pci/msi.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
>index ad33e01..435c195 100644
>--- a/drivers/pci/msi.c
>+++ b/drivers/pci/msi.c
>@@ -94,6 +94,7 @@ static void msi_set_mask_bit(unsigned int 
>irq, int flag)
> 		int offset = entry->msi_attrib.entry_nr * 
>PCI_MSIX_ENTRY_SIZE +
> 			PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
> 		writel(flag, entry->mask_base + offset);
>+		readl(entry->mask_base + offset);
> 		break;
> 	}
> 	default:
>-- 
>1.5.0.4
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/