linux-kernel - Re: [PATCH 6/8] Make non-singlethreaded workqueues freezeable by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070405115714.GA755@tv-sign.ru>
Date:	Thu, 5 Apr 2007 15:57:14 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Gautham R Shenoy <ego@...ibm.com>
Cc:	akpm@...ux-foundation.org, paulmck@...ibm.com,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	vatsa@...ibm.com, "Rafael J. Wysocki" <rjw@...k.pl>, mingo@...e.hu,
	dipankar@...ibm.com, dino@...ibm.com,
	masami.hiramatsu.pt@...achi.com
Subject: Re: [PATCH 6/8] Make non-singlethreaded workqueues freezeable by default

On 04/02, Gautham R Shenoy wrote:
>
> +extern struct workqueue_struct *create_freeze_exempted_workqueue(const char *name, int freeze_exempt_events);
> +
> +extern struct workqueue_struct *create_singlethread_workqueue(const char *name);

I bet akpm will say something about 110-column declaration...

> +struct workqueue_struct *create_workqueue(const char *name)
> +{
> +	return __create_workqueue(name, 0, FE_NONE);
> +}
> +EXPORT_SYMBOL_GPL(create_workqueue);
> +
> +struct workqueue_struct *create_freeze_exempted_workqueue(const char *name,
> +							int freeze_exempt_events)
> +{
> +	return __create_workqueue(name, 0, freeze_exempt_events);
> +}
> +EXPORT_SYMBOL_GPL(create_freeze_exempted_workqueue);
> +
> +struct workqueue_struct *create_singlethread_workqueue(const char *name)
> +{
> +	return __create_workqueue(name, 1, FE_ALL);
> +}
> +EXPORT_SYMBOL_GPL(create_singlethread_workqueue);

EXPORT_SYMBOL() has a cost, and these functions are simple wrappers. How about
static inline?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/