linux-kernel - Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46154006.4090103@oracle.com>
Date:	Thu, 05 Apr 2007 11:29:26 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	David Brownell <david-b@...bell.net>
CC:	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!

David Brownell wrote:
> On Wednesday 04 April 2007 9:18 pm, Randy Dunlap wrote:
> 
>> I don't think it's a MUA thing.  I think David is talking about the
>> spaces after the ^\t that are used for indenting immediately under
>> the "if".
> 
> Exactly.
> 
> 	if (There was a young lady named Bright
> 		Whose speed was far faster than light) {
> 		She set out one day
> 		in a relative way
> 	}
> 	And returned on the previous night
> 
> obeys the only-ident-by-tabs rule, as does
> 
> 	if (To control chain reactions, your odds
> 			Improve if you've got cadmium rods) {
> 		In your fission reactor
> 		Their lack is a factor
> 	}
> 	In screams of "A meltdown! Ye gods!"
> 
> Now, the former makes it hard to tell what's condition vs consequent.
> (Or whatever the correct technical term is in cases like these.)

Yes.  And the second one is just ugly IMHO.
That's why 3 of us (IIRC) have suggested using a few spaces on
multi-line "if" statements rather than many-tabs.  Like so:

> 	if (There was a young lady named Bright
> 	    Whose speed was far faster than light) {
> 		She set out one day
> 		in a relative way
> 	}
> 	And returned on the previous night

but I'm ready to drop it and hope that I never have to look at
that code.  :)

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/