linux-kernel - Re: [PATCH 62/90] ARM: OMAP: Merge board specific files from N800 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070405194854.GY24297@atomide.com>
Date:	Thu, 5 Apr 2007 15:48:58 -0400
From:	Tony Lindgren <tony@...mide.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Kai Svahn <kai.svahn@...ia.com>
Subject: Re: [PATCH 62/90] ARM: OMAP: Merge board specific files from N800 tree

* Randy Dunlap <randy.dunlap@...cle.com> [070404 17:16]:
> On Wed,  4 Apr 2007 14:05:41 -0400 Tony Lindgren wrote:
> 
> > This patch merges board specific files from N800 tree.
> > Nokia has published the files at:
> > 
> 
> 2 comments:
> 
> a.  lots of printk() calls need log levels added as well as some
> indication of the source of the message, like a driver/module name
> or subsystem name[*]

I've update these to use dev_err() or dev_dbg() where possible,
and else use KERN_ERR or KERN_DEBUG.

> b.  externs should be in header files.

Moved them to board-nokia.h.

> * Maybe this isn't so critical for an embedded environment (?)

Updated patch attached.

Tony

View attachment "0062-ARM-OMAP-Merge-board-specific-files-from-N800-tree.txt" of type "text/plain" (41436 bytes)