linux-kernel - Re: [PATCH 6/13] maps: Move the page walker code to lib/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Apr 2007 11:50:12 +1000
From:	Nick Piggin <nickpiggin@...oo.com.au>
To:	Matt Mackall <mpm@...enic.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/13] maps: Move the page walker code to lib/

Nick Piggin wrote:
> Matt Mackall wrote:
> 
>> On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote:

>>> Just put it in its own file in mm/ rather than its own file in lib.
>>> lib should be for almost-standalone stuff, IMO (ie. only using basic
>>> kernel functionality).
>>
>>
>>
>> Arguably that's what lib/ should be for, but it's currently largely
> 
> 
> I disagree. There is code everywhere that exists to provide some
> functionality via an API to other parts of the kernel. You don't
> think mm/page_alloc.c should go in lib/?

Oh, I think I misunderstood you.

Anyway, we have lots of conditionally compiled code in mm as well.
It doesn't seem to be much hardship.

-- 
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/