[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4615924E.8020009@vmware.com>
Date: Thu, 05 Apr 2007 17:20:30 -0700
From: Zachary Amsden <zach@...are.com>
To: Jeremy Fitzhardinge <jeremy@...p.org>
CC: Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...l.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] Bugfix for VMI paravirt ops
Jeremy Fitzhardinge wrote:
> Zachary Amsden wrote:
>
>> No, they are totally dependent. The reason interrupts are disabled is
>> to stop kmap_atomic in interrupt handlers. With the kmap_atomic_pte
>> changes, the whole interrupt disable jibberish goes away.
>>
>
> But kmap_atomic_pte is a special case of kmap_atomic for ptes.
> Interrupt routines can still use plain kmap_atomic for bouncebuffers and
> so on.
>
Ah, yes.
> A more general patch would be to make kmap/unmap_atomic pv_ops, and then
> they can all be rolled together. I.e: check the type to see if special
> pte handling needs to happen, etc.
>
So the clean fix for this is still even further out. I don't think I
want to hook kmap/unmap as paravirt-ops.
Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists