linux-kernel - Re: [PATCH] Deprecate SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070406192937.GA19093@elte.hu>
Date:	Fri, 6 Apr 2007 21:29:37 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	tglx@...utronix.de, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Deprecate SA_xxx interrupt flags -V2


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> Yeah.  I tried something like this and code broke.  For example,
> arch/mips/sni/irq.c has
> 
> struct irqaction sni_isa_irq = {
> 	.handler = sni_isa_irq_handler,
> 	.name = "ISA",
> 	.flags = SA_SHIRQ
> };
> 
> there are presumably only a few such stragglers left in the tree but 
> there are probably more instances out-of-tree.

i quick grep suggests that this seems to be the only one left with a 
similar pattern:

 dione:~/linux/ find . -name '*.[ch]' | xargs grep -E '\..*=.*\<SA_' | 
                grep -vE '\;|\(|=='

 ./arch/mips/sni/irq.c:  .flags = SA_SHIRQ

so the patch is fine to me:

 Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/