linux-kernel - Re: [PATCH] Deprecate SA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1175888217.28263.465.camel@localhost.localdomain>
Date:	Fri, 06 Apr 2007 21:36:57 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] Deprecate SA_xxx interrupt flags -V2

On Fri, 2007-04-06 at 12:22 -0700, Andrew Morton wrote:
> Yeah.  I tried something like this and code broke.  For example,
> arch/mips/sni/irq.c has
> 
> struct irqaction sni_isa_irq = {
> 	.handler = sni_isa_irq_handler,
> 	.name = "ISA",
> 	.flags = SA_SHIRQ
> };

Grr. I fixed that one at least once.

> there are presumably only a few such stragglers left in the tree but there
> are probably more instances out-of-tree.
>
> But I think we should just apply your patch anyway.  Only a small
> proportion of things will break and we do need to be rid of the old
> definitions one day.

For above use cases there is no way of emiting a deprecation warning.
OTOH it leads the user directly to the place, where he can find the fix.
Removing them completely might leave folks clueless.

> It would be great if someone could do another pass across the tree,
> clean up the remaining SA_* usages.

The above seems the only one in Linus tree. I check -mm as well.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/