linux-kernel - Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Apr 2007 14:05:49 -0700
From:	David Brownell <david-b@...bell.net>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

On Friday 06 April 2007 12:03 pm, Stefan Richter wrote:

> 
> I usually indent this way if expressions exceed the 80 columns limit:
> 
> 	if (foo___________ &&
> 	    bar___________) {
> 		doit;
> 	}
> and
> 	if ((one___________ ||
> 	     one_and_a_half) &&
> 	    two___________) {
> 		doit;
> 	}
> and
> 	call(abc_______,
> 	     def___);
> and
> 
> static int definition(abc_______,
> 		      def___)
> {
> ...

Please change your coding style to conform to Documentation/CodingStyle.

	***	Only indent with tabs!!		***

Every one of those examples violates that simple rule.

Why does *anyone* have even the slightest difficulty understanding such a
simple rule?  I realize that two of those words have more than a single
syllable, but that should not be a problem.  Even EMACS is trainable.

> PS:  Everyone please try to avoid blowing CodingStyle up to a 200 pages
> document.  Thanks.

Better yet, try to stick to its guidelines rather than growing lots of
exceptions saying when your personal style says you ought to use spaces
instead of tabs for indents, etc

Randy, next time you criticise coding style, please make sure that the
code in question actually violates the existing rules first ... this
thread has been way too much noise, given that the usage you criticized
was in full conformance with that document, and the proposed fixes were
in blatant violation ...

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/