linux-kernel - Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4616BDA6.7090209@goop.org>
Date:	Fri, 06 Apr 2007 14:37:42 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	David Brownell <david-b@...bell.net>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ...
 blinky leds!!)

David Brownell wrote:
> Please change your coding style to conform to Documentation/CodingStyle.
>
> 	***	Only indent with tabs!!		***
>
> Every one of those examples violates that simple rule.
>   

Spaces are used to indent all over the kernel; using a few spaces to pad
out some indentation into the proper place is accepted practice,
regardless of what CodingStyle says.  The most important rule probably
needs to be explicitly added:

    Break any of these rules sooner than say anything outright barbarous.[1]

Though the first para of CodingStyle is very clear that it is a set of
guidelines rather than strict rules.

    J

1: http://www.k-1.com/Orwell/index.cgi/work/essays/language.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/