linux-kernel - Re: [PATCH] USB gadget rndis: fix bug skb_push function may return an unaligned pointer bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1175826318.17315.57.camel@roc-desktop>
Date:	Fri, 06 Apr 2007 10:25:18 +0800
From:	"Wu, Bryan" <bryan.wu@...log.com>
To:	David Brownell <david-b@...bell.net>, jie.zhang@...log.com,
	roy.huang@...log.com
Cc:	bryan.wu@...log.com, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] USB gadget rndis: fix bug skb_push function may return
	an unaligned pointer bug

On Thu, 2007-04-05 at 14:29 -0700, David Brownell wrote:
> On Tuesday 03 April 2007 11:28 pm, Wu, Bryan wrote:
> > USB gadget rndis: skb_push function may return a pointer which is not
> > aligned as required by struct rndis_packet_msg_type.
> 
> Can you instead try to update the declaration of that struct
> so that it's "__attribute__((packed))"?  That's less invasive,
> and will address similar issues elsewhere ...
> 
> - Dave

OK, Jie and Roy will try to use this __attribute__ method and test it on
blackfin platform. Sorry for missing their "Signed-off-by". I will
resend a patch later for review.

Thanks
-Bryan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/