linux-kernel - Re: [PATCH] Re: kernel oops with badly formatted module option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1176081862.11664.6.camel@localhost.localdomain>
Date:	Mon, 09 Apr 2007 11:24:22 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Re: kernel oops with badly formatted module option

On Sat, 2007-04-07 at 19:47 -0700, Randy Dunlap wrote:
> On Sat, 07 Apr 2007 19:21:01 -0500 Larry Finger wrote:
> 
> > With the following line in /etc/modprobe.conf.local:
> > 
> > options bcm43xx fwpostfix = ".fw3" locale=8
> > 
> > the kernel oops below is generated. I realize that the line should have no whitespace around the 
> > "=", but I do not feel that an oops is the best way to report the syntax error. Could there be a more gentle failure?
> 
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Catch malformed kernel parameter usage of "param = value".
> Spaces are not supported, but don't cause a kernel fault on
> such usage, just report an error.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks Randy,

	I even read your patch before I wrote my own, for a change!

Acked-by: Rusty Russell <rusty@...tcorp.com.au>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/