linux-kernel - Re: fastcalls, was Re: [patch] generic rwsems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070413105905.GB27914@wotan.suse.de>
Date:	Fri, 13 Apr 2007 12:59:05 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: fastcalls, was Re: [patch] generic rwsems

On Fri, Apr 13, 2007 at 11:19:30AM +0100, Christoph Hellwig wrote:
> On Fri, Apr 13, 2007 at 12:04:16PM +0200, Nick Piggin wrote:
> > Remove one level of indirection (kernel/rwsem.c -> lib/rwsem.c), and
> > give a bit of a cleanup (eg remove the fastcall junk) to make the
> > code a bit easier to read.
> 
> Arpopos fastcalls, now that -mregparam=3 is the defaul on i386 and
> FASTCALL/fastcall is a noop everywhere else can we please get rid
> of this attribute entirely?  If any other architecture provides
> a more optimal non-standard calling convention we can just use
> it by default in kernelspace as a few architectures already do.

I don't see why not. David objected me removing them I think because
the rwsem code called some from asm (but of course that's removed too).
However AFAIK, this situation should be using the asmlinkage attribute
anyway.

fastcall in kernel is annoying... it seems to imply that we normally
rather slow calls ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/