linux-kernel - Re: [PATCH] cache_k8_northbridges() overflows beyond allocation (Was: 2.6.21-rc5-mm4 (SLUB))

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Apr 2007 17:45:37 +0200
From:	Andi Kleen <ak@...e.de>
To:	Badari Pulavarty <pbadari@...il.com>
Cc:	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cache_k8_northbridges() overflows beyond allocation (Was: 2.6.21-rc5-mm4 (SLUB))


> 
> cache_k8_northbridges() is storing config values to incorrect locations
> (in flush_words) and also its overflowing beyond the allocation, causing
> slab verification failures.

Oops. Thanks for tracking that down, Badari.

Andrew, clear .21 candidate.

-ANdi

> 
> Signed-off-by: Badari Pulavarty <pbadari@...ibm.com>
> ---
>  arch/x86_64/kernel/k8.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.21-rc6/arch/x86_64/kernel/k8.c
> ===================================================================
> --- linux-2.6.21-rc6.orig/arch/x86_64/kernel/k8.c	2007-04-05 19:36:56.000000000 -0700
> +++ linux-2.6.21-rc6/arch/x86_64/kernel/k8.c	2007-04-13 07:51:57.000000000 -0700
> @@ -61,8 +61,8 @@ int cache_k8_northbridges(void)
>  	dev = NULL;
>  	i = 0;
>  	while ((dev = next_k8_northbridge(dev)) != NULL) {
> -		k8_northbridges[i++] = dev;
> -		pci_read_config_dword(dev, 0x9c, &flush_words[i]);
> +		k8_northbridges[i] = dev;
> +		pci_read_config_dword(dev, 0x9c, &flush_words[i++]);
>  	}
>  	k8_northbridges[i] = NULL;
>  	return 0;
> 
> 
> 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/