lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070418160627.7ab77c30@the-village.bc.nu>
Date:	Wed, 18 Apr 2007 16:06:27 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mark Lord <lkml@....ca>
Cc:	Tejun Heo <htejun@...il.com>, 7eggert@....de,
	Chuck Ebbert <cebbert@...hat.com>,
	emisca <emisca.ml@...il.com>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Adrian Bunk <bunk@...sta.de>,
	Andrew Morton <akpm@...l.org>
Subject: Re: Loud "pop" coming from hard drive on reboot

> +		if (dev->needs_flush && ata_try_flush_cache(dev)) {
>  			return ata_scsi_flush_xlat;
> +			dev->needs_flush = 0;

Works better if you swap the dev-> and return lines

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ