linux-kernel - Re: [patch] slab: resize the alien caches too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46259FEF.9090300@cosmosbay.com>
Date:	Wed, 18 Apr 2007 06:34:55 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
CC:	clameter@....com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] slab: resize the alien caches too

Siddha, Suresh B a écrit :
> Christoph,
> 
> While going through the slab code, I observed that alien caches are
> not getting resized, when user changes the slab tunables. Appended patch
> tries to fix this. Please review and let me know if I missed anything.
> 
> thanks,
> suresh
> ---
> 
> Resize the alien caches too based on the slab tunables.
> 
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> ---
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 4cbac24..e0dd9af 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3823,6 +3823,7 @@ static int alloc_kmemlist(struct kmem_cache *cachep)
>  		l3 = cachep->nodelists[node];
>  		if (l3) {
>  			struct array_cache *shared = l3->shared;
> +			struct array_cache **alien = l3->alien;
>  
>  			spin_lock_irq(&l3->list_lock);
>  

Christoph already rejected the patch, but I have one further comment : 
l3->alien should be fetched after spin_lock_irq() of course.

It's true that the :
if (limit > 1) limit = 12;
from alloc_alien_cache() is quite disturbing and could be cleaned up.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/