linux-kernel - Re: [PATCH] use spinlock instead of binary mutex in idt77252 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070423065520.GR5013@traven>
Date:	Mon, 23 Apr 2007 08:55:20 +0200
From:	Matthias Kaehlcke <matthias.kaehlcke@...il.com>
To:	Kyle Moffett <mrmacman_g4@....com>
Cc:	chas@....nrl.navy.mil, ecd@...com.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use spinlock instead of binary mutex in idt77252 driver

El Sun, Apr 22, 2007 at 07:50:36PM -0400 Kyle Moffett ha dit:

> On Apr 22, 2007, at 17:39:59, Matthias Kaehlcke wrote:
> >use spinlock instead of binary mutex in idt77252 driver
> 
> I think you really meant: "Use mutex instead of binary semaphore in  
> idt77252 driver", since this is a binary semaphore (not a mutex,  
> which are always binary):
> >-	struct semaphore	mutex;
> 
> and this is a mutex, not a spinlock:
> >+	struct mutex		mutex;
> 
> Everything else looks good though

you're totally right. like in another patch i sent at the same time i
messed up the description. as you point out it should read "Use mutex
instead of binary semaphore in idt77252 driver". in the last days i
reported some spinlock related bugs, i suppose that made me write
spinlock instead of mutex ...

thanks for your comments

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

                If you don't know where you are going,
               you will probably end up somewhere else
                         (Laurence J. Peter)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/