linux-kernel - RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BF571719A4041A478005EF3F08EA6DF00433242E@pcsmail03.pcs.pc.ome.toshiba.co.jp>
Date:	Thu, 26 Apr 2007 16:27:42 +0900
From:	"Tomita, Haruo" <haruo.tomita@...hiba.co.jp>
To:	"Jan Beulich" <jbeulich@...ell.com>
Cc:	<prarit@...hat.com>, "lkml" <linux-kernel@...r.kernel.org>,
	"Tomita, Haruo" <haruo.tomita@...hiba.co.jp>
Subject: RE: [PATCH 2/2]  Fixed typo Intel RNG driver for2.6.21-rc7-mm1

Hi Jan,

Thank you for the comment.
 
> ># Do you think that a "FWH not detected" message is noisy?
> 
> No, I think it helps understanding why there's no RNG device 
> in the system.

OK, the typo fixes patch was corrected.

 intel-rng.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~	2007-04-26 13:41:53.000000000 +0900
+++ linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c	2007-04-26 16:26:16.000000000 +0900
@@ -365,7 +365,8 @@ static int __init mod_init(void)
 	pci_dev_put(dev);
 	iounmap(intel_rng_hw->mem);
 	kfree(intel_rng_hw);
-	goto out;
+	if (err)
+		goto out;
 
 fwh_done:
 	err = -ENOMEM;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/