linux-kernel - [PATCH] Add vDSO for x86-64 with gettimeofday/clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2007 16:50:06 +0100
From:	mel@...net.ie (Mel Gorman)
To:	Andi Kleen <ak@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steve Fox <drfickle@...ibm.com>,
	Andy Whitcroft <apw@...dowen.org>
Subject: [PATCH] Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu fix

On (27/04/07 09:59), Mel Gorman didst pronounce:
> On (27/04/07 02:39), Andi Kleen didst pronounce:
> > 
> > 
> > > That's vdso.lds.S, not vdso.lds. The VDSO_TEXT_OFFSET is still 0x400.
> > > This is what I should have posted the last time
> > > 
> > > --- build/arch/x86_64/vdso/voffset.h.orig	2007-04-26 08:43:31.523739878 -0700
> > > +++ build/arch/x86_64/vdso/voffset.h	2007-04-26 08:43:38.839579356 -0700
> > > @@ -1 +1 @@
> > > -#define VDSO_TEXT_OFFSET 0x500
> > > +#define VDSO_TEXT_OFFSET 0x400
> > 
> > It's definitely 0x400 here. Is your patch reversed and you want 0x500? 
> > 
> 
> Sorry, that patch is reversed. It's 0x500 it needs to be to work here.
> 

What I should have done in the first place..... Sorry for the noise.

=======

The machine elm3b6 on test.kernel.org had problems with the patch
x86_64-mm-vdso.patch. The fix is two-fold. The first patch fixes a compile
problem by adding -m64.  This patch updates VDSO_TEXT_OFFSET so that the
linker does not complain.

Signed-off-by: Mel Gorman <mel@....ul.ie>
---
 voffset.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.21-rc7-mm2-quilt/arch/x86_64/vdso/voffset.h
===================================================================
--- linux-2.6.21-rc7-mm2-quilt.orig/arch/x86_64/vdso/voffset.h	2007-04-27 10:35:09.000000000 +0100
+++ linux-2.6.21-rc7-mm2-quilt/arch/x86_64/vdso/voffset.h	2007-04-27 10:35:12.000000000 +0100
@@ -1 +1 @@
-#define VDSO_TEXT_OFFSET 0x400
+#define VDSO_TEXT_OFFSET 0x500
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/