linux-kernel - Re: [PATCH] Add vDSO for x86-64 with gettimeofday/clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704271834.13249.ak@suse.de>
Date:	Fri, 27 Apr 2007 18:34:13 +0200
From:	Andi Kleen <ak@...e.de>
To:	Mel Gorman <mel@...net.ie>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Steve Fox <drfickle@...ibm.com>,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH] Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu fix

On Friday 27 April 2007 17:50:06 Mel Gorman wrote:
> On (27/04/07 09:59), Mel Gorman didst pronounce:
> > On (27/04/07 02:39), Andi Kleen didst pronounce:
> > > 
> > > 
> > > > That's vdso.lds.S, not vdso.lds. The VDSO_TEXT_OFFSET is still 0x400.
> > > > This is what I should have posted the last time
> > > > 
> > > > --- build/arch/x86_64/vdso/voffset.h.orig	2007-04-26 08:43:31.523739878 -0700
> > > > +++ build/arch/x86_64/vdso/voffset.h	2007-04-26 08:43:38.839579356 -0700
> > > > @@ -1 +1 @@
> > > > -#define VDSO_TEXT_OFFSET 0x500
> > > > +#define VDSO_TEXT_OFFSET 0x400
> > > 
> > > It's definitely 0x400 here. Is your patch reversed and you want 0x500? 
> > > 
> > 
> > Sorry, that patch is reversed. It's 0x500 it needs to be to work here.
> > 
> 
> What I should have done in the first place..... Sorry for the noise.

I had already fixed it up. 

But now can you test Suresh's latest patch too please?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/