linux-kernel - Re: [PATCH -mm 2/2] Introduce freezer flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070427163347.GD22639@in.ibm.com>
Date:	Fri, 27 Apr 2007 22:03:47 +0530
From:	Gautham R Shenoy <ego@...ibm.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Oleg Nesterov <oleg@...sign.ru>,
	Pavel Machek <pavel@....cz>,
	Pekka Enberg <penberg@...helsinki.fi>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 2/2] Introduce freezer flags

On Fri, Apr 27, 2007 at 06:19:40PM +0200, Sam Ravnborg wrote:
> On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote:
> 
> > --- linux-2.6.21-rc7-mm2.orig/kernel/fork.c
> > +++ linux-2.6.21-rc7-mm2/kernel/fork.c
> > @@ -921,11 +921,14 @@ static inline void copy_flags(unsigned l
> >  {
> >  	unsigned long new_flags = p->flags;
> >  
> > -	new_flags &= ~(PF_SUPERPRIV | PF_NOFREEZE);
> > +	new_flags &= ~PF_SUPERPRIV;
> >  	new_flags |= PF_FORKNOEXEC;
> >  	if (!(clone_flags & CLONE_PTRACE))
> >  		p->ptrace = 0;
> >  	p->flags = new_flags;
> > +#ifdef CONFIG_FREEZER
> > +	p->freezer_flags = 0;
> > +#endif
> >  }
> Could we have a dedicated clear_freeze_flag() so we could drop the ifdef?
> 
> > +		clear_freeze_flag(p);

That means something else. clear_freeze_flag() just clears the 
TFF_FREEZE flag and not necessarily everything.

Besides, this is the only place where we would need to clear all the bits
of p->freezer_flags. Not sure if having a static inline helper function 
is worth it.

> 
> Or maybe we have it already?

We don't yet. But can if badly needed :-)
> 
> 
> 	Sam

Thanks and Regards
gautham.
-- 
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/