linux-kernel - Re: [patch] uml: fix cmpxchg warnings in -mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2007 19:27:48 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	jdike@...toit.com, linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [patch] uml: fix cmpxchg warnings in -mm

On Fri, Apr 27, 2007 at 06:18:02PM +0200, Miklos Szeredi wrote:
> 
> From: Miklos Szeredi <mszeredi@...e.cz>
> 
> I get lot's of these on i386:
> 
> In file included from include/asm/atomic.h:10,
>                  from include/linux/file.h:9,
>                  from mm/fadvise.c:12:
> include/asm/arch/atomic.h: In function ‘atomic_add_unless’:
> include/asm/arch/atomic.h:240: warning: implicit declaration of function ‘cmpxchg’
> [...]
> 
> The problem seems to be that <asm-i386/atomic.h> assumes that
> <asm/processor.h> pulls in <asm/system.h>.

Then atomic.h should include system.h and not rely on someone else doing it.
Yes - then system.h may be included twice but that's ok.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/