linux-kernel - Re: Driver core: warn when userspace writes to the uevent file in a non-supported way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070427223411.01cfecae@the-village.bc.nu>
Date:	Fri, 27 Apr 2007 22:34:11 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	torvalds@...l.org
Subject: Re: Driver core: warn when userspace writes to the uevent file in a
 non-supported way

>     In the future we will allow the uevent type to be written to the uevent
>     file to trigger the different types of uevents.  But for now, as we only
>     support the ADD event, warn if userspace tries to write anything else to
>     this file.
>     
>     Signed-off-by: Kay Sievers <kay.sievers@...y.org>
>     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> ---
>  drivers/base/core.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 72c6ee5..f69305c 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -296,6 +296,9 @@ out:
>  static ssize_t store_uevent(struct device *dev, struct device_attribute *attr,
>  			    const char *buf, size_t count)
>  {
> +	if (memcmp(buf, "add", 3) != 0)
> +		dev_err(dev, "uevent: unsupported action-string; this will "
> +			"be ignored in a future kernel version");

Warnings good, lack of rate limiting extremely bad indeed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/