linux-kernel - Re: [PATCH -mm 2/2] Introduce freezer flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200704280009.19639.rjw@sisk.pl>
Date:	Sat, 28 Apr 2007 00:09:18 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	ego@...ibm.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Oleg Nesterov <oleg@...sign.ru>,
	Pavel Machek <pavel@....cz>,
	Pekka Enberg <penberg@...helsinki.fi>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm 2/2] Introduce freezer flags

On Friday, 27 April 2007 23:49, Rafael J. Wysocki wrote:
> On Friday, 27 April 2007 23:40, Gautham R Shenoy wrote:
> > On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rjw@...k.pl>
> > > 
> > > Move all of the freezer-related flags to a separate field in task_struct and
> > > introduce functions to operate them using set_bit() etc.
> > > 
> > > 
> > > Index: linux-2.6.21-rc7-mm2/include/linux/sched.h
> > > ===================================================================
> > > --- linux-2.6.21-rc7-mm2.orig/include/linux/sched.h
> > > +++ linux-2.6.21-rc7-mm2/include/linux/sched.h
> > > @@ -1006,7 +1006,10 @@ struct task_struct {
> > >  	/* Deadlock detection and priority inheritance handling */
> > >  	struct rt_mutex_waiter *pi_blocked_on;
> > >  #endif
> > > -
> > > +#ifdef CONFIG_FREEZER
> > > +	/* Used by the process freezer, defined in freezer.h */
> > > +	unsigned int freezer_flags;
> > 
> > unsigned long freezer_flags; ??
> 
> I guess so.

Still, on x86_64, for example, we'll waste 4 bytes by using 'unsigned long'
here, which I wouldn't like to do.

Is it acceptable to use explicit type casting in set_bit() and friends?

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/