linux-kernel - Re: [PATCH] hugetlbfs: fix error path in module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070428161856.GA9662@APFDCB5C>
Date:	Sun, 29 Apr 2007 01:18:56 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	William Lee Irwin III <wli@...omorphy.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] hugetlbfs: fix error path in module_init

On Sat, Apr 28, 2007 at 07:50:39AM -0700, William Lee Irwin III wrote:
> On Sat, Apr 28, 2007 at 04:19:23PM +0900, Akinobu Mita wrote:
> > init_hugetlbfs_fs() needs to unregister hugetlbfs
> > when kern_mount() returns error.
> > Cc: William Irwin <wli@...omorphy.com>
> > Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> 
> This patch resolves a clear failure to error check.

I reconsider this patch. It was wrong. Because it is overkill to
unregister filesystem just for hugetlbfs_vfsmount mount failure.
Because hugetlbfs_vfsmount is only used for shumget() system call
and also there is some race condition between register_filesystem()
and unregister_filesystem(). (it's not likely happen though)

So what we can do for hugetlbfs module_init failure is
adding NULL check for hugetlbfs_vfsmount in hugetlb_zero_setup().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/