linux-kernel - Re: checkpatch, a patch checking script.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46338E61.1080708@garzik.org>
Date:	Sat, 28 Apr 2007 14:11:45 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dave Jones <davej@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: checkpatch, a patch checking script.

Dave Jones wrote:
> On Sat, Apr 28, 2007 at 03:02:13AM -0700, Andrew Morton wrote:
> 
>  > This little checking tool should have both "error" and "warning" levels -
>  > AKA "fix this" and "think about this" levels.  BUG_ON would be a warning
>  > thing.
> 
> There's a -pedantic option there just for this.  I'll move BUG_ON under it.
> What's the consensus on the u32 thing, move that too, or drop completely?

Not answering your question directly, but FWIW:  In day to day coding 
and email, I strongly advocate the use of u8/u16/u32 over the C99 
size-based types.

Simple, direct (read: easiest to review), and less typing.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/