linux-kernel - Re: Flaws with "UIO: Add the User IO core code" (with patch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070428212416.5768cc04@the-village.bc.nu>
Date:	Sat, 28 Apr 2007 21:24:16 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Hans-Jürgen Koch <hjk@...utronix.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	torvalds@...l.org, Thomas Gleixner <tglx@...utronix.de>,
	Benedikt Spranger <b.spranger@...utronix.de>
Subject: Re: Flaws with "UIO: Add the User IO core code" (with patch)

> > AFAIK we don't currently have any platform that runs binaries with
> > different sizes of "int" but this is a) an unsigned value anyway, and b)
> > should be a fixed type (eg u32)
> 
> I reviewed the code once more and find it OK. There is only one legal
> value for the parameter "count" of uio_read(), and that's sizeof(int).

If you are a box with multiple supported binary types how big is an
"int". We use explicit sizes to ensure that uio_read() will work when/if
we get platforms which support binaries with differing ideas of the size
of "int". Thus it should use s32 or s64 or similar.

> The data that is actually read is the element "event" of struct uio_device,
> which is of type atomic_t. The latter has the size of an int.

The latter is the size of a kernel "int".

Other patch looks fine.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/