linux-kernel - Re: checkpatch, a patch checking script.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaodl9m4ia.fsf@cisco.com>
Date:	Fri, 27 Apr 2007 22:50:37 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dave Jones <davej@...hat.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: checkpatch, a patch checking script.

 > box:/usr/src/25> ~/checkpatch.pl patches/git-infiniband.patch 

Yup, I ran this too.

 > Checking patches/git-infiniband.patch:  signoffs = 113
 > Use WARN_ON & Recovery code rather than BUG() and BUG_ON()
 > 8143:+  BUG_ON(mlx4_ib_alloc_db_from_pgdir(pgdir, db, order));
 > 12629:+ BUG_ON(cmd->free_head < 0);
 > 16580:+         BUG_ON(index < dev->caps.num_mgms);
 > 16665:+                 BUG_ON(amgm_index_to_free < dev->caps.num_mgms);
 > 16681:+         BUG_ON(index < dev->caps.num_mgms);

I agree -- killing the kernel for a driver bug is dump.  I'll remove
all these BUGs before merging.

 > Don't init statics to 0/NULL:
 > 10333:+         path->static_rate = 0;

This is a false positive/opportunity for script improvement, obviously.

 > 15461:+static int msi_x = 0;
 > 16113:+ static int mlx4_version_printed = 0;

Already zapped these.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/