linux-kernel - Re: [PATCH] [30/30] x86_64: Add missing !X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070501062132.GQ25929@bingen.suse.de>
Date:	Tue, 1 May 2007 08:21:32 +0200
From:	Andi Kleen <ak@...e.de>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Andi Kleen <ak@...e.de>, ebiederm@...ssion.com, patches@...-64.org,
	linux-kernel@...r.kernel.org, bill.irwin@...cle.com
Subject: Re: [PATCH] [30/30] x86_64: Add missing !X86_PAE dependincy to the 2G/2G split.

On Tue, May 01, 2007 at 06:26:23AM +0200, Eric Dumazet wrote:
> Andi Kleen a ?crit :
> >From: ebiederm@...ssion.com
> >
> >When in PAE mode we require that the user kernel divide to be
> >on a 1G boundary.  The 2G/2G split does not have that property
> >so require !X86_PAE
> >
> >Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> >---
> > arch/i386/Kconfig |    1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> >index 1a94a73..80003de 100644
> >--- a/arch/i386/Kconfig
> >+++ b/arch/i386/Kconfig
> >@@ -570,6 +570,7 @@ choice
> > 		depends on !HIGHMEM
> > 		bool "3G/1G user/kernel split (for full 1G low memory)"
> > 	config VMSPLIT_2G
> >+		depends on !X86_PAE
> > 		bool "2G/2G user/kernel split"
> > 	config VMSPLIT_1G
> > 		bool "1G/3G user/kernel split"
> 
> Hum... We lose a usefull 2G/2G split. Should'nt we use a patch to change 
> PAGE_OFFSET to 0x8000000 instead of 0x78000000 and keep 2G/2G split ?

I dropped the patch for now.

> [PATCH] i386 : Adjust CONFIG_PAGE_OFFSET in case of 2G/2G split and X86_PAE
> 
> When in PAE mode we require that the user kernel divide to be
> on a 1G boundary.  We must therefore make sure PAGE_OFFSET is correctlty 
> defined in the 2G/2G split and PAE mode.

Looks reasonable. Did you test both cases? wli, ok for you too?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/