linux-kernel - Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 May 2007 18:31:07 +0200 (CEST)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Linus Torvalds <torvalds@...l.org>, Andrew Morton <akpm@...l.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC. 

On Tue, 1 May 2007, David Howells wrote:
> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > This causes a compile failure on m68k:
> 
> Hmmm... I couldn't actually test m68k as I couldn't get it to compile.  Can
> you give me a good config I can use as a base?
> 
> > | linux/fs/afs/fsclient.c: In function 'afs_deliver_fs_fetch_data':
> > | linux/fs/afs/fsclient.c:269: warning: dereferencing 'void *' pointer
> > | linux/fs/afs/fsclient.c:269: error: request for member 'virtual' in something not a structure or union
> 
> Ummm...  Maybe m68k kmap_atomic() should cast it...  I think everywhere else
> it must be an inline function or something.

On architectures that #define WANT_PAGE_VIRTUAL (frv/m68k/mips/extensa),
page_address(page) expands to (page)->virtual, which fails if page is a
void *.

> However, I'll subsume your patch into mine if you don't mind.

Please apply ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/