linux-kernel - Re: condingstyle, was Re: utrace comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705011312h44245a54k89ac9344424548be@mail.gmail.com>
Date:	Wed, 2 May 2007 01:42:20 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"John Anthony Kazos Jr." <jakj@...-k-j.com>
Cc:	"David Woodhouse" <dwmw2@...radead.org>,
	"Geert Uytterhoeven" <geert@...ux-m68k.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Christoph Hellwig" <hch@...radead.org>,
	"Roland McGrath" <roland@...hat.com>,
	"Christoph Hellwig" <hch@....de>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: condingstyle, was Re: utrace comments

On 5/1/07, John Anthony Kazos Jr. <jakj@...-k-j.com> wrote:
> > It's horrid. I'd much rather see
> >
> >         if (veryverylengthycondition1 &&
> >             smallcond2 &&
> >             (conditionnumber3a || condition3b)) {
> >                 ...
> >         }
>
>         if (veryverylengthycondition1
>                 && smallcond2
>                 && (conditionnumber3a
>                         || condition3b)) {
>                 ...
>         }
>
> Clear, crisp, and 80-wide. I also like how the logical operator on the
> following line is indented slightly into the condition of the previous
> line. I think this is much more sensical and sensible than using spaces to
> line them up with the parentheses. Makes clear for each operator the
> condition to which it applies.

Hmmm ... I did use the spaces to line up the operators with the
starting column of the _expression_ in the previous lines, not the
parentheses (that would be gross!). Of course, && and || are binary
operators so they apply both to the expression on the previous line as
well as the expression following it on the same line.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/