linux-kernel - Re: [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200705021246.51039.ak@novell.com>
Date:	Wed, 2 May 2007 12:46:50 +0200
From:	Andi Kleen <ak@...ell.com>
To:	Chuck Ebbert <cebbert@...hat.com>
Cc:	patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [24/30] x86_64: Shut up warnings for vfat compat ioctls on other file systems

On Tuesday 01 May 2007 17:45:52 Chuck Ebbert wrote:
> Andi Kleen wrote:
> > vfat implements compat handlers for these ioctls, but when they
> > were executed on other file systems the kernel would still complain
> > about an unknown compat ioctl.  Just declare them as compatible
> > and let them be rejected when not needed by the normal path.
> > 
> > This makes wine runs a lot quieter
> 
> Does this also restore the original -ENOTTY return code?
> 
> The change that made it return -EINVAL broke a few Wine apps.

No it's still EINVAL as before. I just eliminated the printks.

I guess one could add a IGNORE_IOCTL_ENOTTY() or somesuch though if it's 
really a problem.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/