linux-kernel - Re: condingstyle, was Re: utrace comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 May 2007 20:18:51 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	David Howells <dhowells@...hat.com>
Cc:	"John Anthony Kazos Jr." <jakj@...-k-j.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Satyam Sharma <satyam.sharma@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Roland McGrath <roland@...hat.com>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: condingstyle, was Re: utrace comments

David Howells <dhowells@...hat.com> writes:

> John Anthony Kazos Jr. <jakj@...-k-j.com> wrote:
>
>> 	if (veryverylengthycondition1
>> 		&& smallcond2
>> 		&& (conditionnumber3a
>> 			|| condition3b)) {
>> 		...
>> 	}
>> 
>> Clear, crisp, and 80-wide. I also like how the logical operator on the 
>> following line is indented slightly into the condition of the previous 
>> line.
>
> The brain works better when associated things are lined up, so:
>
> 	if (veryverylengthycondition1 &&
> 	    smallcond2 &&
> 	    (conditionnumber3a ||
> 	     condition3b)) {
>
> is better as it gives a visual clue to association.

Not lining up with the code following the if statement is also
a plus.  Because it clearly delineates the conditions from the code.

Of course in many cases conditions this complex are candidates for

if (!condition1)
	continue;
if (!condition2)
	continue;
if (!condition3a && !condition3b)
	continue;

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/