linux-kernel - Re: dead CONFIG_ variables: drivers/scsi/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070503112250.GE12018@flint.arm.linux.org.uk>
Date:	Thu, 3 May 2007 12:22:50 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org
Subject: Re: dead CONFIG_ variables:  drivers/scsi/

On Thu, May 03, 2007 at 07:17:34AM -0400, Robert P. J. Day wrote:
> p.s.  "CONFIG_" prefix aside, i would think it's also a bit yucky to
> be checking for the definition of a preprocessor symbol that you've
> already hardcoded out of existence in the same source file.  :-)

No, because the way you turn them on (as intended) is to do:

perl -pi -e 's/undef/define/ if m/CONFIG_ACORNSCSI_CONSTANTS/' \
 drivers/scsi/arm/acornscsi.c

(or via your text editor).

An alternative way around the issue is to keep a separate patch
outside of mainline which patches the additional code and data into
the driver.  That's far less maintainable, and leads to additional
problems.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/