linux-kernel - [PATCH] drivers/message/i2o/device.c: remove redundant GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705041835530.13758@cselinux1.cse.iitk.ac.in>
Date:	Fri, 4 May 2007 18:58:23 +0530 (IST)
From:	Satyam Sharma <ssatyam@....iitk.ac.in>
To:	linux-kernel@...r.kernel.org
cc:	akpm@...ux-foundation.org, rpjday@...dspring.com,
	alan@...rguk.ukuu.org.uk, markus.lidel@...dowconnect.com
Subject: [PATCH] drivers/message/i2o/device.c: remove redundant GFP_ATOMIC
 from kmalloc

drivers/message/i2o/device.c:i2o_parm_field_get() unnecessarily passes 
GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not 
atomic. Remove the pointless GFP_ATOMIC.

 	Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in>

---

diff -ruNp linux-2.6.21.1/drivers/message/i2o/device.c linux-2.6.21.1~patch/drivers/message/i2o/device.c
--- linux-2.6.21.1/drivers/message/i2o/device.c	2007-04-26 08:38:32.000000000 +0530
+++ linux-2.6.21.1~patch/drivers/message/i2o/device.c	2007-05-04 17:48:30.000000000 +0530
@@ -485,7 +485,7 @@ int i2o_parm_field_get(struct i2o_device
  	u8 *resblk;		/* 8 bytes for header */
  	int rc;

-	resblk = kmalloc(buflen + 8, GFP_KERNEL | GFP_ATOMIC);
+	resblk = kmalloc(buflen + 8, GFP_KERNEL);
  	if (!resblk)
  		return -ENOMEM;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/