linux-kernel - [PATCH] drivers/scsi/aic7xxx_old.c: remove redundant GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705041858260.13758@cselinux1.cse.iitk.ac.in>
Date:	Fri, 4 May 2007 19:01:08 +0530 (IST)
From:	Satyam Sharma <ssatyam@....iitk.ac.in>
To:	linux-kernel@...r.kernel.org
cc:	akpm@...ux-foundation.org, rpjday@...dspring.com,
	james.bottomley@...eleye.com, linux-scsi@...r.kernel.org,
	dledford@...hat.com
Subject: [PATCH] drivers/scsi/aic7xxx_old.c: remove redundant GFP_ATOMIC from
 kmalloc

drivers/scsi/aic7xxx_old.c:aic7xxx_slave_alloc() unnecessarily passes 
GFP_ATOMIC (along with GFP_KERNEL) to kmalloc() from a context that is not 
atomic. Remove the pointless GFP_ATOMIC.

 	Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in>

---

diff -ruNp linux-2.6.21.1/drivers/scsi/aic7xxx_old.c linux-2.6.21.1~patch/drivers/scsi/aic7xxx_old.c
--- linux-2.6.21.1/drivers/scsi/aic7xxx_old.c	2007-04-26 08:38:32.000000000 +0530
+++ linux-2.6.21.1~patch/drivers/scsi/aic7xxx_old.c	2007-05-04 17:47:26.000000000 +0530
@@ -6581,7 +6581,7 @@ aic7xxx_slave_alloc(struct scsi_device *
    struct aic7xxx_host *p = (struct aic7xxx_host *)SDptr->host->hostdata;
    struct aic_dev_data *aic_dev;

-  aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_ATOMIC | GFP_KERNEL);
+  aic_dev = kmalloc(sizeof(struct aic_dev_data), GFP_KERNEL);
    if(!aic_dev)
      return 1;
    /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/