linux-kernel - Re: [linux-cifs-client] Re: SMB2 file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <524f69650705041135i7633cd34xd0b03bc2abd25c2@mail.gmail.com>
Date:	Fri, 4 May 2007 13:35:44 -0500
From:	"Steve French" <smfrench@...il.com>
To:	"Jeremy Allison" <jra@...ba.org>
Cc:	"Gerald Carter" <coffeedude.jerry@...il.com>,
	simo <idra@...ba.org>, "Christoph Hellwig" <hch@...radead.org>,
	linux-cifs-client@...ts.samba.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-cifs-client] Re: SMB2 file system - should it be a distinct module

On 5/4/07, Jeremy Allison <jra@...ba.org> wrote:
> On Thu, May 03, 2007 at 09:46:05AM -0500, Gerald Carter wrote:
> > Long term I agree that CIFS and SMB2 should be in the same .ko
>
> Actually I disagree. I think Christoph is correct. These
> are two independent protocols and should be in two different
> modules.
>
> > But NTLM 0.12 still works for Vista and DFS referrals.
> > Breaking out SMB2 initially means that it will not clutter
> > the working cifs.ko code.  Remember that an SMB2 client fs is
> > mostly research at this point, and not engineering.
>
> Long term the common functions should be factored out
> and put into a lower-level module that both cifs and
> SMB2 are dependent upon.
>
> That's the cleaner solution IMHO.
>
> Jeremy.

There is also the obvious tradeoff of  "easier to update frequently"
vs. "easier to write" which is a primary factor.

1) as distinct .ko files smb2 and cifs can be updated independently
(the former marked broken/experimental).  Updating smb2 won't
risk breaking cifs

2)  but implemented in the same module, there is somewhat less code to write.




-- 
Thanks,

Steve
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/