linux-kernel - Re: [linux-pm] [RFT][PATCH] swsusp: Change code ordering related to ACPI

Open Source and information security mailing list archives

Message-ID: <8f8ff01d0705041136r18315079w13f95dc3c627a53b@mail.gmail.com>
Date:	Fri, 4 May 2007 22:36:41 +0400
From:	"Alexey Starikovskiy" <aystarik@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Tobias Diedrich" <ranma+kernel@...edrich.de>,
	"pm list" <linux-pm@...ts.linux-foundation.org>,
	"Pavel Machek" <pavel@....cz>, "Marcus Better" <marcus@...ter.se>
Subject: Re: [linux-pm] [RFT][PATCH] swsusp: Change code ordering related to ACPI

Doing _WAK (from pm_finish) before device_resume will brake almost all
ACPI devices.

Regards,
Alex.

On 5/4/07, Rafael J. Wysocki <rjw@...k.pl> wrote:
> Hi,
>
> The change of the hibernation/suspend code ordering made before 2.6.21 has
> caused some systems to have problems related to ACPI.  In particular, the
> 'platform' hibernation mode doesn't work any more on some systems.
>
> It has been confirmed that the appended patch fixes the problem, but it's not
> certain if this changes don't break some other systems.  For this reason, all
> users of hibernation (swsusp, uswsusp) are gently requested to verify if this
> patch doesn't break their systems.
>
> Greetings,
> Rafael
>
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
>
> The current code ordering in the hibernation code paths causes some systems to
> have problems.  It has been confirmed by testers that these problems do not
> appear if the acpi_pm_finish() function (called via platform_finish()) is
> executed after device_suspend().
>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  kernel/power/disk.c |    4 ++--
>  kernel/power/user.c |    8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-2.6.21/kernel/power/disk.c
> ===================================================================
> --- linux-2.6.21.orig/kernel/power/disk.c       2007-05-04 10:31:51.000000000 +0200
> +++ linux-2.6.21/kernel/power/disk.c    2007-05-04 10:32:12.000000000 +0200
> @@ -195,9 +195,9 @@ int hibernate(void)
>
>         if (in_suspend) {
>                 enable_nonboot_cpus();
> -               platform_finish();
>                 device_resume();
>                 resume_console();
> +               platform_finish();
>                 pr_debug("PM: writing image.\n");
>                 error = swsusp_write();
>                 if (!error)
> @@ -214,9 +214,9 @@ int hibernate(void)
>   Enable_cpus:
>         enable_nonboot_cpus();
>   Resume_devices:
> -       platform_finish();
>         device_resume();
>         resume_console();
> +       platform_finish();
>   Thaw:
>         mutex_unlock(&pm_mutex);
>         unprepare_processes();
> Index: linux-2.6.21/kernel/power/user.c
> ===================================================================
> --- linux-2.6.21.orig/kernel/power/user.c       2007-05-04 10:31:51.000000000 +0200
> +++ linux-2.6.21/kernel/power/user.c    2007-05-04 10:32:12.000000000 +0200
> @@ -169,11 +169,11 @@ static inline int snapshot_suspend(int p
>         }
>         enable_nonboot_cpus();
>   Resume_devices:
> +       device_resume();
> +       resume_console();
>         if (platform_suspend)
>                 platform_finish();
>
> -       device_resume();
> -       resume_console();
>   Finish:
>         mutex_unlock(&pm_mutex);
>         return error;
> @@ -201,11 +201,11 @@ static inline int snapshot_restore(int p
>
>         enable_nonboot_cpus();
>   Resume_devices:
> +       device_resume();
> +       resume_console();
>         if (platform_suspend)
>                 platform_finish();
>
> -       device_resume();
> -       resume_console();
>   Finish:
>         pm_restore_console();
>         mutex_unlock(&pm_mutex);
> _______________________________________________
> linux-pm mailing list
> linux-pm@...ts.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/linux-pm
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives