linux-kernel - Re: [2.6.22 patch] iop: combined watchdog timer driver for iop3xx and iop13xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070506205320.GA6486@infomag.infomag.iguana.be>
Date:	Sun, 6 May 2007 22:53:20 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Dan Williams <dan.j.williams@...il.com>
Cc:	"Curt E. Bruns" <curt.e.bruns@...el.com>,
	Peter Milne <peter.milne@...acq.com>,
	Russell King <rmk@....linux.org.uk>,
	linux-kernel@...r.kernel.org,
	Lennert Buytenhek <buytenh@...tstofly.org>
Subject: Re: [2.6.22 patch] iop: combined watchdog timer driver for iop3xx and iop13xx

Hi Dan,

> >Could you split this patch into 2 patches: one that deals with the moving 
> >of
> >the architecture dependant code (and explaining why) and one with the new
> >watchdog drivers? I will continue my review today.
> >
> 
> I am one of the maintainers of this architecture, (Lennert Buytenhek
> is the other).  I will go ahead and split this up so you can sign-off
> on the watchdog specific bits.  The intent is to move all hardware
> definitions under #include <asm/hardware.h>.  You are right this
> should have been a separate patch.

I reviewed the rest of the code. Looks OK to me. One small remark though:
Can we change the ifdef's in the code as described in section 2 point 2 of
the Documentation/SubmittingPatches document?

Thanks,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/