linux-kernel - Re: [PATCH 8/8] One Laptop Per Child power/battery driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070507203812.GA18400@elf.ucw.cz>
Date:	Mon, 7 May 2007 22:38:12 +0200
From:	Pavel Machek <pavel@....cz>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Anton Vorontsov <cbou@...l.ru>, Greg KH <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, kernel-discuss@...dhelds.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 8/8] One Laptop Per Child power/battery driver

On Mon 2007-05-07 20:51:37, David Woodhouse wrote:
> On Mon, 2007-05-07 at 19:49 +0000, Pavel Machek wrote:
> > We had this discussion before. Kernel sources should be us-ascii.
> > utf-8 is ok for documentation. 
> 
> /* This _is_ documentation. Go away. */

No, that's a comment. Fix your code.

(And besides, comments are supposed to be useful. Patch contained
something like...

int voltage; /* ??V */

...which is pretty unhelpful. We still stick to 80 columns in the
code, and bigger displays certainly predate utf-8 compatibility. Plus,
you'd have to convert large part of Czech republic before I could
reasonably use utf-8).
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/