linux-kernel - Re: [PATCH -mm] PM: Separate hibernation code from suspend code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178613696.18162.28.camel@johannes.berg>
Date:	Tue, 08 May 2007 10:41:36 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>,
	Nigel Cunningham <nigel@...el.suspend2.net>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH -mm] PM: Separate hibernation code from suspend code

On Mon, 2007-05-07 at 23:35 +0200, Rafael J. Wysocki wrote:

> > Also, you could then simplify all the instances of
> >   (hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops) 
> > to just
> >   (hibernation_mode == HIBERNATION_PLATFORM)
> > in various if statements and other places.
> 
> No, that's not a good idea, because of the "reduce code duplication patch"
> that I'd like to go on top of this.  I'd rather use 'if (hibernation_ops)' here. :-)

But if you want the user to be able to change away from 'platform' mode
you still have to have
  if (hibernation_ops && hibernation_mode == HIBERNATION_PLATFORM)
in most places, no?

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)