linux-kernel - Re: [patch 010/455] block_write_full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <46406595.2000205@yahoo.fr>
Date:	Tue, 08 May 2007 13:57:09 +0200
From:	Guillaume Chazarain <guichaz@...oo.fr>
To:	akpm@...ux-foundation.org
CC:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 010/455] block_write_full_page(): report ENOSPC

akpm@...ux-foundation.org a écrit :
> block_write_full_page() forgot to propagate ENPSOC into the address_space.

> --- a/fs/buffer.c~block_write_full_page-handle-enospc
> +++ a/fs/buffer.c
> @@ -1727,6 +1727,7 @@ recover:
>  	} while ((bh = bh->b_this_page) != head);
>  	SetPageError(page);
>  	BUG_ON(PageWriteback(page));
> +	mapping_set_error(page->mapping, err);
>  	set_page_writeback(page);
>  	do {
>  		struct buffer_head *next = bh->b_this_page;

As I said in http://lkml.org/lkml/2007/2/9/336 I am not aware of any 
call stack where the error is dropped here.

So, this patch should not harm but I am not sure it does any good.

Thanks.

-- 
Guillaume
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/