[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5d6222a80705090507h4fdbf4f5x439d3991c1c9b7b8@mail.gmail.com>
Date: Wed, 9 May 2007 09:07:19 -0300
From: "Glauber de Oliveira Costa" <glommer@...il.com>
To: "David Howells" <dhowells@...hat.com>
Cc: torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
npiggin@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix a bad bug in read_cache_page_async()
> page = __read_cache_page(mapping, index, filler, data);
> if (IS_ERR(page))
> - goto out;
> + goto error;
any reason for not simply returning page here?
> page = ERR_PTR(err);
> + goto error;
same
--
Glauber de Oliveira Costa.
"Free as in Freedom"
"The less confident you are, the more serious you have to act."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists