linux-kernel - Re: [PATCH] Fix a bad bug in read_cache_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070509121937.GA24026@wotan.suse.de>
Date:	Wed, 9 May 2007 14:19:37 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix a bad bug in read_cache_page_async()

On Wed, May 09, 2007 at 01:02:01PM +0100, David Howells wrote:
> Fix a bad bug in read_cache_page_async() introduced in commit:
> 
> 	6fe6900e1e5b6fa9e5c59aa5061f244fe3f467e2
> 
> This adds:
> 
> 	mark_page_accessed(page)
> 
> into the error handling path in read_cache_page_async().  In such a case,
> 'page' holds the error code.

Obvious thinko. Thanks, ack.

> 
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  mm/filemap.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 9e56fd1..10d4fcf 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1784,7 +1784,7 @@ struct page *read_cache_page_async(struct address_space *mapping,
>  retry:
>  	page = __read_cache_page(mapping, index, filler, data);
>  	if (IS_ERR(page))
> -		goto out;
> +		goto error;
>  	mark_page_accessed(page);
>  	if (PageUptodate(page))
>  		goto out;
> @@ -1803,9 +1803,11 @@ retry:
>  	if (err < 0) {
>  		page_cache_release(page);
>  		page = ERR_PTR(err);
> +		goto error;
>  	}
> - out:
> +out:
>  	mark_page_accessed(page);
> +error:
>  	return page;
>  }
>  EXPORT_SYMBOL(read_cache_page_async);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/