linux-kernel - Re: [bisect] NFS regression breaks X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178749064.6760.14.camel@heimdal.trondhjem.org>
Date:	Wed, 09 May 2007 18:17:44 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jeff Garzik <jeff@...zik.org>,
	Chuck Lever <chuck.lever@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	NeilBrown <neilb@...e.de>, Adrian Bunk <bunk@...sta.de>
Subject: Re: [bisect] NFS regression breaks X

On Wed, 2007-05-09 at 14:51 -0700, Linus Torvalds wrote:
> 
> On Wed, 9 May 2007, Jeff Garzik wrote:
> > 
> > I love bisect :)
> 
> Yeah, me too.
> 
> > bisect has identified the following commit as the one that
> > causes my GNOME login to die, within 10 seconds of logging in:
> > 
> > 	commit 2bea90d43a050bbc4021d44e59beb34f384438db
> 
> Ok, that commit looks nice in many ways, so I'd be loathe to revert it 
> entirely.
> 
> Can you try it with this patch that re-introduces the "total overkill" 
> slack calculations, and probably makes them even worse (there's a few 
> left-shifts added, and now it will left-shift the extra slacktoo).
> 
> But there are also some unexplained changes in that patch, so maybe the 
> size allocation isn't the big problem. For example, now "call_allocate()" 
> will set task->tk_status to zero which is totally strange.
> 
> But if it's the allocation that is too small, this patch may help.
> 
> Trond, Chuck?

We'd really like to fix this by getting the pre-allocation tables right
in nfs4xdr.c. Chuck has already identified one incorrect value:

http://linux-nfs.org/cgi-bin/gitweb.cgi?p=nfs-2.6.git;a=commitdiff;h=6ce7dc940701cf3fde3c6e826a696b333092cbb1;hp=aa3d1faebe6e214cd96be0e587571477ff6fd9fc

that I just asked you to pull as part of a series of bugfixes. I'm
hoping that will suffice to fix Jeff's case too.

Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/