linux-kernel - [PATCH] Fix warning when building fs/afs/super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 11 May 2007 16:47:45 +1000
From:	tony@...eyournoodle.com (Tony Breeds)
To:	Linux Kernel ML <linux-kernel@...r.kernel.org>
Subject: [PATCH] Fix warning when building fs/afs/super.c


Fix build waning in fs/afs/super.c

fs/afs/super.c: In function 'afs_parse_options':
fs/afs/super.c:153: warning: passing argument 2 of 'match_token' discards qualifiers from pointer target type

AFS declares it's match_table as const, which is discrded in lib/parser.c.
match_token() doesn't modify the table so making it const should be safe.

Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
---
 include/linux/parser.h |    2 +-
 lib/parser.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: working/include/linux/parser.h
===================================================================
--- working.orig/include/linux/parser.h
+++ working/include/linux/parser.h
@@ -25,7 +25,7 @@ typedef struct {
 	char *to;
 } substring_t;
 
-int match_token(char *, match_table_t table, substring_t args[]);
+int match_token(char *, const match_table_t table, substring_t args[]);
 int match_int(substring_t *, int *result);
 int match_octal(substring_t *, int *result);
 int match_hex(substring_t *, int *result);
Index: working/lib/parser.c
===================================================================
--- working.orig/lib/parser.c
+++ working/lib/parser.c
@@ -100,7 +100,7 @@ static int match_one(char *s, const char
  * format identifiers which will be taken into account when matching the
  * tokens, and whose locations will be returned in the @args array.
  */
-int match_token(char *s, match_table_t table, substring_t args[])
+int match_token(char *s, const match_table_t table, substring_t args[])
 {
 	const struct match_token *p;
 
Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/