linux-kernel - Re: Is this a preempt issue in drivers/input/evdev.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705120105.40699.dtor@insightbb.com>
Date:	Sat, 12 May 2007 01:05:40 -0400
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	"Yin,Fengwei" <yfw.kernel@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Is this a preempt issue in drivers/input/evdev.c

Hi,

On Friday 11 May 2007 23:18, Yin,Fengwei wrote:
> 
> So if the evdev_release() is preempted at the point marked by another
> process which will open the evdev, which will make operation sequence
> like:
> 
>    --evdev->open in evdev_release()
>          -----> preempted
> 	                            evdev->open++ and input_open_devie()
> 	 <----- reschedule 
> 	input_close_device()
> 
> Should we introduce a mutex here? Or do I miss something? Thanks.
> 

Locking is completely absent in evdev. There was a patch introducing
locking in recent -mm's but it got dropped. I need to refresh it.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/